-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): make environment specs managed attributes #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aar65537 for the contribution, it is a great improvement to the library! I just have one comment regarding the ActionSpec
which I think we should not have.
Please let me know what you think!
Sorry for the radio silence, I still want to get this in! What do you think about using cached_properties instead of properties as the spec should never change? |
I think |
True, but we know what the cached properties are, so we could call them in the base env classes |
Also just a heads up, we're making a push to get sliding tile puzzle and flatpack envs merged before the ICLR camera ready deadline (about a week). Once this is done we'll get to this PR 😄 |
Thanks for the heads up. I changed all of the environments to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @aar65537, really nice change 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me! Except that we are missing changes for at least SlidingTilePuzzle since we merged it. Could we possibly port these specs changes to that 22nd environment as well, please?
I've implemented the changes for the SlidingTilePuzzle and cleaned up the last references to |
closes #98
_*_spec
properties on the Environment class. The properties are accessed through*_spec
managed attributes implemented with the@property
decorator. Properties are initialized with_make_*_spec()
methods during Environment initialization.ActionSpec
type on the Environment class in order to statically type theaction_spec
attribute.*_spec()
method to*_spec
attribute.Edit:
now also closes #221
Observation
type onEnvironment