-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastAPI: capture responseHeadersOnEntrySpans #488
Conversation
Signed-off-by: Varsha GS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I have requested a couple of small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one comment, It looks good to me.
Signed-off-by: Varsha GS <[email protected]>
- capture a list of headers Signed-off-by: Varsha GS <[email protected]>
Signed-off-by: Varsha GS <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
FastAPI: capture responseHeadersOnEntrySpans
Signed-off-by: Varsha GS [email protected]