-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add facilities for unit and functional tests #165
Conversation
This pull request has merge conflicts that must be resolved before it can be |
32b8217
to
a5dc505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over all these changes and honestly everything LGTM - thank you for this @danmcp!
Two nits - one is in the comment, the other would be it'd be nice to add a badge for this new workflow similar to what is done for the CLI here: https://github.com/instructlab/instructlab/blob/main/README.md?plain=1#L4
Done! |
There was one unit test already existing and this commit adds a couple of starter unit tests for mt_bench and mmlu. Signed-off-by: Dan McPherson <[email protected]>
There was already 1 unit test in place. The existing functional tests are being moved to scripts for consistency with other projects.
One new functional test has been added to test the mt_bench_branch generator as a starting example
I've included basic tests for mt_bench and mmlu. Which already found two issues: