update README, requirements.txt #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Kunstle <[email protected]>
danmcp
reviewed
Jun 26, 2024
| @@ -10,3 +10,4 @@ accelerate | |||
| pandas | |||
| pandas-stubs | |||
| lm-eval>=0.4.2 | |||
| instructlab | |||
There was a problem hiding this comment.
This doesn't seem right. Why is it needed here?
There was a problem hiding this comment.
Yeah we can't have this here - it's a circular dependency
There was a problem hiding this comment.
You can put it in requirements-dev.txt to get it installed for unit testing. You don't want it in your prod requirements.txt though.
This bit me over here: instructlab/sdg#28
There was a problem hiding this comment.
++ good feedback, this was something I needed for testing.
danmcp
reviewed
Jun 26, 2024
| @@ -30,6 +30,9 @@ pip install vllm | |||
| python -m vllm.entrypoints.openai.api_server --model instructlab/granite-7b-lab --tensor-parallel-size 1 | |||
| ``` | |||
|
|
|||
| > Note: You may need to be specific about which Python version you use for your virtual environment. | |||
| > e.g. `python3.11 -m venv venv` is supported. | |||
There was a problem hiding this comment.
Noting I submitted a PR to update cloud-instance as well: instructlab/instructlab#1487
russellb
requested changes
Jun 27, 2024
|
closing because I don't think the addition is relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues that I ran into when trying to run tests.