-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial skeleton for Evaluator classes and exceptions #6
Conversation
Signed-off-by: Nathan Weinberg <[email protected]>
2f36b52
to
50adbe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - are PR-MMLU and PR-Bench going to live in the MMLU and MT-Bench child classes respectively or is the idea to add them in later as their own child classes?
Good question! I think we could go with either approach - either extending the current child classes or adding new child classes but in the same files. Could you do an explicit approval? I've set the repo so two are required for merge. @alimaredia same for you. @danmcp and @xukai92 feel free to weigh-in as well - this foundation will define subsequent work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lean towards new child classes since the inputs/dependencies differ across PR benchmarks. You could add them in this PR or it can be handled in a follow-up PR by anyone.
Thanks for working on this!!
Signed-off-by: Nathan Weinberg <[email protected]>
It would be good to understand the signatures before deciding. But I'm pretty sure they should be new classes. The other thing to consider whether the modeling makes more sense as a is-a or has-a relationship. Has-a might give some useful flexibility. |
I pushed up two additional child classes based on the specs in the doc - lmk your thoughts! |
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
8f1eb48
to
0023da3
Compare
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
d9204eb
to
11ad758
Compare
Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Nathan Weinberg <[email protected]>
0f50072
to
b422048
Compare
Signed-off-by: Nathan Weinberg <[email protected]>
This PR introduces the
Evaluator
parent class and theMMLUEvaluator
andMTBenchEvaluator
child classesIt also introduces the
EvalError
parent exception class for alleval
custom exceptions and theModelNotFoundError
child exception class