Fix TaxonomyReadingException message not displaying
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
requested changes
Dec 18, 2024
courtneypacheco
force-pushed
the
fix-taxonomy-exception-class
branch
from
f8c9ba3 to
c0c1348
Compare
|
@instructlab/schema-maintainers once this is merged please cut a |
Add `pass` to ensure that the message shows and and we get what we expect. Update unit tests to confirm. Signed-off-by: Courtney Pacheco <[email protected]>
courtneypacheco
force-pushed
the
fix-taxonomy-exception-class
branch
from
c0c1348 to
b49c6ef
Compare
bjhargrave
approved these changes
Dec 18, 2024
Released: https://pypi.org/project/instructlab-schema/0.4.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75
To ensure the exception message gets printed, we need to either define an
__init__function in the customTaxonomyReadingExceptionclass OR addpass.I opted for the latter approach and added unit tests to confirm the exception message gets printed/returned.