filterblock: add default_value for use with convert_dtype #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark McLoughlin <[email protected]>
Fixes instructlab#133 We have been using None as a default value when dtype conversion fails. This works fine with the eq operator, but not others e.g. ge In many cases a default like zero or False works fine, but there are cases where the pipeline author will need to specify a different default, for example when using something like `le(1)` you would want a default greater than 1. With this change, we're acknowledging that this is default value handling is very normal, and we can drop from error logging to debug logging. Signed-off-by: Mark McLoughlin <[email protected]>
|
Also fixes #123 |
russellb
approved these changes
Jul 16, 2024
jwm4
pushed a commit
to jwm4/sdg
that referenced
this pull request
Dec 13, 2024
…_actions/actions/checkout-4.2.1 Bump actions/checkout from 4.2.0 to 4.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
We have been using None as a default value when dtype conversion fails. This works fine with the eq operator, but not others e.g. ge
In many cases a default like zero or False works fine, but there are cases where the pipeline author will need to specify a different default, for example when using something like
le(1)you would want a default greater than 1.With this change, we're acknowledging that this is default value handling is very normal, and we can drop from error logging to debug logging.