chore: Change default temporary write directory in all e2e CI jobs from tmpfs to /home/tmp
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid physical memory restrictions set in place for `tmpfs` (aka `/tmp`) that prevent us from utilzing more than 50% of the available physical memory on our EBS. Signed-off-by: Courtney Pacheco <[email protected]>
courtneypacheco
force-pushed
the
update-default-tmp-dir-path
branch
from
b158de7 to
63e1d9e
Compare
nathan-weinberg
approved these changes
Jan 10, 2025
|
@bbrowning yep, it should in theory! i think we should leave that issue open for maybe ~2 weeks to see if the issue has been resolved by this PR, or if it still occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the same issue originally identified in instructlab/instructlab#2866, where we noticed intermittent OOM issues during some of our e2e CI jobs.
While I have not noticed any OOM issues recently in this repo, updating the default temporary write directory from
tmpfs(aka/tmp) to/home/tmpshould mitigate the risk of OOM errors occurring in our e2e CI jobs since we'll now theoretically have access to 100% of the available physical memory in our EBS volume, instead of only 50%.