📚 Adding Knowledge llm blocks #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhi1092
commented
Jun 27, 2024
abhi1092
commented
- 🧩 Conditional Block for conditionally picking prompt templates and parsing function
- 🎛️ Changes in the Sampling block to handle post_fixes
- 🐞 Bug fix for _parse function in LLMBlock
added 6 commits
June 27, 2024 18:18
Signed-off-by: Abhi.B <[email protected]>
🔧 Implemented conditional llmblock 🐛 Fixed minor bugs Signed-off-by: Abhi.B <[email protected]>
Signed-off-by: Abhi.B <[email protected]>
Signed-off-by: Abhi.B <[email protected]>
Signed-off-by: Abhi.B <[email protected]>
Signed-off-by: Abhi.B <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Oindrilla Chatterjee <[email protected]>
oindrillac
approved these changes
Jun 27, 2024
|
I noticed that this PR changed the format expected from the dataset given to the pipeline. The CLI integration we just merged matched the old format. (We merged it after this, I just missed that this change impacted it.) This made me realize that the skills templates expect something different, as well. I filed #55 as a follow-up to this issue. |
russellb
added a commit
to russellb/sdg
that referenced
this pull request
Jun 30, 2024
PR instructlab#50 changed the format used in the full knowledge pipeline. Change the simple pipelines to match. Part of issue instructlab#55. Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.