Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pipeline schema for IterBlock #526

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

bbrowning
Copy link
Contributor

When reconciling the SDG code, we forgot to add a schema entry for IterBlock. This does that, which will fix the CI failure hit in PR #518

When reconciling the SDG code, we forgot to add a schema entry for
IterBlock. This does that, which will fix the CI failure hit in PR instructlab#518

Signed-off-by: Ben Browning <[email protected]>
Copy link
Contributor

@eshwarprasadS eshwarprasadS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good catch ✅

Copy link
Member

@khaledsulayman khaledsulayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mergify mergify bot added the one-approval label Jan 29, 2025
@mergify mergify bot merged commit d4a7136 into instructlab:main Jan 29, 2025
10 checks passed
@mergify mergify bot removed the one-approval label Jan 29, 2025
@bbrowning bbrowning deleted the iterblock-pipeline-schema branch January 31, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants