Fix prompt file paths for an installed library #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each subclass was calculating the root directory of the python package for finding prompt templates that are embedded in the package. Move this to the base `Flow` class so we're only doing it in one place. Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
prompt-file-paths
branch
from
3e01b18 to
3c6123f
Compare
Special handling is required to find these prompt files from an installed version of the instructlab-sdg package. This updates the rest of this file to make use of `self.sdg_base` from the base `Flow` class which will work from an installed library. Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
prompt-file-paths
branch
from
3c6123f to
a906660
Compare
|
Nice catch, thanks for separating the no-op refactor and bugfix into separate commits - lgtm |
oindrillac
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2debc77 default_flows: Move sdg_base into base Flow class
3e01b18 Fix remaining prompt file paths
commit 2debc77
Author: Russell Bryant [email protected]
Date: Tue Jul 2 16:36:28 2024 -0400
commit 3e01b18112fbabd418f028697288366d1c3f8ae5
Author: Russell Bryant [email protected]
Date: Tue Jul 2 16:42:21 2024 -0400