generate_data: fix support for multiple leaf nodes #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, 👍 Do you understand why e2e was passing with this bug? |
Yes. It tested all taxonomy types, but one at a time. I ran it with two by accident locally and hit this. Test coverage improvement is needed. I will file an issue to fix this. |
|
Test coverage issue to fix e2e. Easy fix, should be able to do it tomorrow instructlab/instructlab#1599 |
danmcp
approved these changes
Jul 8, 2024
|
This pull request has merge conflicts that must be resolved before it can be |
When running generate_data() with a taxonomy with more than one leaf node, the code previously appended the resulting datasets as if they behaved like a Python list. They are a `datasets.Dataset` and do not support the `+` operator. Instead, keep a list of these datasets. Also update the code that writes these results to a file to handle the extra level of iteration now required. Signed-off-by: Russell Bryant <[email protected]>
russellb
force-pushed
the
fix-multiple-output-datasets
branch
from
29b703e to
3834f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running generate_data() with a taxonomy with more than one leaf
node, the code previously appended the resulting datasets as if they
behaved like a Python list. They are a
datasets.Datasetand do notsupport the
+operator.Instead, keep a list of these datasets. Also update the code that
writes these results to a file to handle the extra level of iteration
now required.
Signed-off-by: Russell Bryant [email protected]