-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external client check + google #193
Conversation
🦋 Changeset detectedLatest commit: 869c0ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to cbfb9af in 29 seconds
More details
- Looked at
349
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. src/instructor.ts:478
- Draft comment:
Removing the 'baseURL' check in the 'isGenericClient' function might lead to incorrect identification of a generic client. Consider verifying if this change aligns with the intended logic. - Reason this comment was not posted:
Comment did not seem useful.
2. src/instructor.ts:475
- Draft comment:
Function and method names should follow consistent patterns. Consider renamingisGenericClient
to follow the same pattern as other methods. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
3. src/instructor.ts:478
- Draft comment:
If library code changes, ensure that documentation is updated to reflect the removal of 'baseURL' check inisGenericClient
. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_zLuxbXy6AM941pj5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a25005a in 29 seconds
More details
- Looked at
11
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .changeset/eleven-needles-fry.md:5
- Draft comment:
Ensure that the changeset description is clear and matches the actual changes in the code. If the baseUrl check removal affects functionality, it should be documented here. - Reason this comment was not posted:
Confidence changes required:50%
The changeset file is correctly formatted and provides a clear description of the changes made in the PR.
2. .changeset/eleven-needles-fry.md:1
- Draft comment:
Ensure this new markdown file is added to mkdocs.yml. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_6vHQfz2rw6nQQ8Fy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 869c0ed in 19 seconds
More details
- Looked at
27
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/test-pr.yml:25
- Draft comment:
Ensure that theGEMINI_API_KEY
secret is correctly set in the repository settings to avoid runtime errors. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the GEMINI_API_KEY is consistent across both workflow files, ensuring that the secret is available for both PR and main branch tests.
2. .github/workflows/test-pr.yml:25
- Draft comment:
Ensure that documentation and tests are updated to reflect the addition ofGEMINI_API_KEY
. This applies to bothtest-pr.yml
andtest.yml
. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_XaYxoDfk9Uc2sU40
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Update dependencies, remove
baseURL
check in type guard, and add Google client tests.baseURL
check fromisGenericClient()
ininstructor.ts
.GEMINI_API_KEY
to environment variables intest-pr.yml
andtest.yml
.@anthropic-ai/sdk
to0.33.1
,llm-polyglot
to2.5.0
, andopenai
to4.78.1
inpackage.json
.bun
to1.1.43
in.tool-versions
.google.test.ts
for testing Google client integration with various scenarios.This description was created by for 869c0ed. It will automatically update as commits are pushed.