Skip to content

Commit

Permalink
remove broken loop
Browse files Browse the repository at this point in the history
the key to this hash is [spec_name, platform], not simply name, so this
loop was never doing anything. it will likely come back soon, in a fixed
form, but is breaking my next commit that I don't want to fix this loop
yet
  • Loading branch information
ccutrer committed May 18, 2024
1 parent 6288305 commit 15fd388
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions lib/bundler/multilock.rb
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ def after_install_all(install: true)
Bundler.ui.info("Syncing to #{relative_lockfile}...") if attempts == 1
synced_any = true

specs = lockfile_name.exist? ? cache.specs(lockfile_name) : {}
parent_lockfile_name = lockfile_definition[:parent]
parent_root = parent_lockfile_name.dirname
parent_specs = cache.specs(parent_lockfile_name)
Expand Down Expand Up @@ -253,19 +252,6 @@ def after_install_all(install: true)
spec,
parent_spec)

# look through all reverse dependencies; if any of them say it
# has to come from self, due to conflicts, then this gem has
# to come from self as well
[cache.reverse_dependencies(lockfile_name),
cache.reverse_dependencies(parent_lockfile_name)].each do |reverse_dependencies|
break if precedence == :self

reverse_dependencies[spec.name].each do |dep_name|
precedence = check_precedence.call(specs[dep_name], parent_specs[dep_name])
break if precedence == :self
end
end

spec_precedences[spec.name] = precedence || :parent
end

Expand Down

0 comments on commit 15fd388

Please sign in to comment.