improve inferences on if mismatched dependencies are intentional #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccutrer
force-pushed
the
improve-mismatched-deps-inferences
branch
from
051ef9c to
fa8c301
Compare
basically, makes it so that we don't have to re-sync lockfiles every time when you have disjunctions on the same gem (i.e. rails) between lockfiles due to the improved logic, deprecate the allow_mismatched_dependencies param entirely.
ccutrer
force-pushed
the
improve-mismatched-deps-inferences
branch
from
fa8c301 to
79fa76a
Compare
maths22
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically, makes it so that we don't have to re-sync lockfiles every time when you have disjunctions on the same gem (i.e. rails) between lockfiles
due to the improved logic, deprecate the allow_mismatched_dependencies param entirely.