Skip to content

Commit

Permalink
[MBL-17822][Teacher] Filtering submissions by section doesn't open th…
Browse files Browse the repository at this point in the history
…e correct students submission (#2545)

refs: MBL-17822
affects: Teacher
release note: Fixed a bug, where the incorrect student's submission was opened in SpeedGrader in some cases.

* fix selection

* fix clearing section filter
  • Loading branch information
hermannakos authored Sep 2, 2024
1 parent 64ad900 commit 2dea9ee
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ class AssignmentSubmissionListFragment : BaseSyncFragment<
selectedIdx = selectedIdx,
anonymousGrading = assignment.anonymousGrading,
filter = presenter.getFilter(),
filterValue = presenter.getFilterPoints()
filterValue = presenter.getFilterPoints(),
filteredSubmissionIds = filteredSubmissions.map { it.id }.toLongArray(),
)
RouteMatcher.route(requireActivity(), Route(bundle, RouteContext.SPEED_GRADER))
}
Expand Down Expand Up @@ -206,8 +207,8 @@ class AssignmentSubmissionListFragment : BaseSyncFragment<

private fun setupListeners() = with(binding) {
clearFilterTextView.setOnClickListener {
presenter.setFilter(SubmissionListFilter.ALL)
presenter.clearFilterList()
presenter.setFilter(SubmissionListFilter.ALL)
filterTitle.setText(R.string.all_submissions)
clearFilterTextView.setGone()
}
Expand Down

0 comments on commit 2dea9ee

Please sign in to comment.