Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-17755][All] Added inbox signature to inbox compose screen #2790

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

tamaskozmer
Copy link
Contributor

@tamaskozmer tamaskozmer commented Feb 10, 2025

Test plan:

  • Allow inbox signature option in your sandbox.
  • Set an inbox signature on web.
  • Check that it's added to new messages and replies.

refs: MBL-17755
affects: Student, Teacher, Parent
release note: Inbox signature is now added to inbox messages.

Checklist

  • Tested in light mode
  • A11y checked

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@domonkosadam domonkosadam self-requested a review February 10, 2025 14:44
@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

Copy link
Contributor

@domonkosadam domonkosadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Contributor

@kdeakinstructure kdeakinstructure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 👍

@inst-danger
Copy link
Contributor

Native Parent Install Page

# Conflicts:
#	libs/pandautils/src/main/java/com/instructure/pandautils/features/inbox/compose/InboxComposeViewModel.kt
@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@tamaskozmer tamaskozmer merged commit 1e3aede into master Feb 12, 2025
4 checks passed
@tamaskozmer tamaskozmer deleted the MBL-17755-add-inbox-signature branch February 12, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants