Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not merge - bitrise testing #3025

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Do not merge - bitrise testing #3025

wants to merge 30 commits into from

Conversation

vargaat
Copy link
Contributor

@vargaat vargaat commented Dec 12, 2024 •
edited
Loading

Student, Teacher, Parent

vargaat added 23 commits December 12, 2024 11:03
@vargaat
Add empty yml.
898ebd0
@vargaat
Add common workflows and a dedicated yml for adhoc builds.
465017d
@vargaat
Remove include.
0518271
@vargaat
Remove adhoc workflows, re-add include.
cb0b901
@vargaat
Add empty workflow to adhoc yml.
583d46e
@vargaat
Add discovery workflow.
70bcc23
@vargaat
Add adhoc utility step.
af1c60f
@vargaat
Remove unnecessary trigger.
083b143
@vargaat
Rename adhoc yml.
ca157c8
@vargaat
Add build triggers to each app.
9b83dd3
@vargaat
Move comment to main workflow.
cefe818
@vargaat
Extract QR code based on the built scheme.
a18f195
@vargaat
Fix QR key. Add unified QR code table as comment.
59f4cf4
@vargaat
Fix variable name. Omit clean operation before builds.
9008448
@vargaat
Add back updated PR comment step.
3ea1e7e
@vargaat
Add PR trigger.
1c3a2cd
@vargaat
Don't run PR comment step if workflow failed.
11b4808
@vargaat
Add human readable status report name.
3c32627
@vargaat
Don't use utility workflow format for adhoc build.
62affbe
@vargaat
Reference the outer yml when starting sub-build.
312d28b
@vargaat
Update build number update step to its latest version.
bf85b12
@vargaat
Extract app icon location to an external variable since it differs in…
8cab76a 
… the Horizon app.
@vargaat
Enable verbose loggin for xcode build.
841b12c
@vargaat vargaat self-assigned this Dec 13, 2024
@inst-danger
Copy link
Contributor

Builds

@inst-danger
Copy link
Contributor

Builds

Student

@inst-danger
Copy link
Contributor

Builds

Student

@inst-danger
Copy link
Contributor

Builds

Student

@vargaat vargaat closed this Dec 13, 2024
@vargaat vargaat reopened this Dec 13, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Dec 13, 2024 •
edited
Loading

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 13, 2024 •
edited
Loading

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 13, 2024 •
edited
Loading

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 13, 2024 •
edited
Loading

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor 
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")
❌ XCTest failed: CoreTests/CoreSearchHostingControllerTests/test_search_experience_started 
XCTAssertEqual failed: ("") is not equal to ("Example")

Generated by 🚫 dangerJS against 33f94ae

@inst-danger
Copy link
Contributor

Builds

Student
Teacher
Parent

@inst-danger
Copy link
Contributor

inst-danger commented Dec 16, 2024 •
edited
Loading

Builds

Student
Teacher
Parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabinst szabinst Awaiting requested review from szabinst szabinst will be requested when the pull request is marked ready for review szabinst is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 will be requested when the pull request is marked ready for review rh12 is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz will be requested when the pull request is marked ready for review ndrsszsz is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst will be requested when the pull request is marked ready for review suhaibabsi-inst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vargaat vargaat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaat @inst-danger