-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter screens consolidation #3038
Draft
rh12
wants to merge
25
commits into
master
Choose a base branch
from
hackweek/MBL-18544-Filter-Screens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18544 affects: Student, Teacher release note: Improved various filter screens. test plan: See PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18544
affects: Student, Teacher
release note: Improved various filter screens.
TODO
What's changed
Added
SingleSelectionView
andMultiSelectionView
components (and their viewmodels) to handle selections, typically found on Filter or Preferences screens.Added
OptionItem
as the model for these, which is a stripped down, unified model for all option selections.SingleSelectionOptions
andMultiSelectionOptions
group them together for simplified usage.id
as aString
instead of making it generic. For simplicity and because it covers most cases.OptionItemConvertible
at the moment.Updated the following screens to use these:
Consolidated UI in accordance with UX designer (Figma update is WIP)
What's not changed
Test plan
Verify all the above screens work as before, including the interactions with their List screens.
There is no updated Figma for each of the screens, so please check the screenshots below for UI changes.
Screenshots
Checklist