Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Horizon] Update dashboard & add LearningObjectCard component #3039

Open
wants to merge 2 commits into
base: feature/horizon
Choose a base branch
from

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93 Ahmed-Naguib93 commented Dec 20, 2024

Update Dashboard
https://instructure.atlassian.net/browse/CLX-151
LearningObjectCard card component
https://instructure.atlassian.net/browse/CLX-294

Please note:
I made some changes to the Pill component and Typography because I encountered issues when updating the dashboard. We need to align with the team once they return from the holiday.

Simulator Screenshot - iPhone 15 Pro Max - 2024-12-20 at 15 14 55
Simulator Screenshot - iPhone 15 Pro Max - 2024-12-20 at 15 16 22

@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Dec 20, 2024
@Ahmed-Naguib93 Ahmed-Naguib93 changed the title [Horizon] Update dashboard & add LearningObjectCard card component [Horizon] Update dashboard & add LearningObjectCard component Dec 20, 2024
@inst-danger
Copy link
Contributor

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")
❌ XCTest failed: CoreTests/CoreSearchHostingControllerTests/test_search_experience_started
XCTAssertEqual failed: ("") is not equal to ("Example")

Generated by 🚫 dangerJS against 33e338d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants