Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen #3042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix E2E test issue with Grading Periods Not being shown correctly on Grades Filter screen #3042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Core/Core/Grades/View/GradeListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public struct GradeListView: View, ScreenViewTrackable {
: .textLightest)

}
.hidden(viewModel.state == .initialLoading)
.accessibilityLabel(Text("Filter", bundle: .core))
.accessibilityHint(Text("Filter grades options", bundle: .core))
.accessibilityIdentifier("GradeList.filterButton")
Expand Down
1 change: 0 additions & 1 deletion Student/StudentE2ETests/Grades/GradingPeriodsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class GradingPeriodsTests: E2ETestCase {
typealias Helper = GradesHelper

func testGradingPeriodsFilter() throws {
try XCTSkipIf(true, "Skipped because of MBL-18023.")
// MARK: Seed the usual stuff with grading periods containing graded assignments
let student = seeder.createUser()
let enrollmentTerm = Helper.createEnrollmentTerm()
Expand Down