Request stringified IDs from Canvas

Shard-qualified IDs can get too large for JS to represent as numeric, and it does weird things in this scenario closes MAT-921 flag=none test plan - Find an RCE - Insert -> Document -> Coures Documents - Switch to "All" view * In Network Inspector, verify that the IDs that come back on the requests to the Folders API are strings It's not really possible to repro the production issue locally due to highly specific requirements on shard ID; we will have to validate in Change-Id: I7cf95e087bf513a12cae1a7ae1870e8fe76fc13b Reviewed-on: https://gerrit.instructure.com/c/canvas-rce-api/+/303763 Tested-by: Service Cloud Jenkins <[email protected]> Reviewed-by: Joe Hernandez <[email protected]> QA-Review: Joe Hernandez <[email protected]> Product-Review: Jon Scheiding <[email protected]>
instructure · Oct 25, 2022 · d8c2d04 · d8c2d04
1 parent 7ec2263
commit d8c2d04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,4 @@ docker-compose.override.yml
 coverage/
 .nyc_output/
 .env
+.vscode
diff --git a/app/api/canvasProxy.js b/app/api/canvasProxy.js
@@ -20,7 +20,8 @@ function requestHeaders(tokenString, req) {
     Authorization: "Bearer " + tokenString,
     "User-Agent": req.get("User-Agent"),
     "X-Request-Context-Id": Buffer.from(req.id).toString("base64"),
-    "X-Request-Context-Signature": reqIdSignature
+    "X-Request-Context-Signature": reqIdSignature,
+    Accept: "application/json+canvas-string-ids"
   };
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,3 +4,4 @@ docker-compose.override.yml @@
     coverage/
     .nyc_output/
     .env
+    .vscode