WIP(ui-top-nav-bar): add lightMode

instructure · Sep 13, 2024 · 88fafe3 · 88fafe3
1 parent 72b7733
commit 88fafe3
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 9 deletions.
diff --git a/packages/__docs__/src/App/index.tsx b/packages/__docs__/src/App/index.tsx
@@ -33,6 +33,7 @@ import {
 } from 'react'
 
 import { Alert } from '@instructure/ui-alerts'
+import { Checkbox } from '@instructure/ui-checkbox'
 import { InstUISettingsProvider, withStyle, jsx } from '@instructure/emotion'
 import { Flex } from '@instructure/ui-flex'
 import { Text } from '@instructure/ui-text'
@@ -55,7 +56,6 @@ import {
   IconUserLine,
   IconXSolid
 } from '@instructure/ui-icons'
-
 import { ContentWrap } from '../ContentWrap'
 import { Document } from '../Document'
 import { Header } from '../Header'
@@ -69,7 +69,6 @@ import { Icons } from '../Icons'
 import { compileMarkdown } from '../compileMarkdown'
 
 import { fetchVersionData, versionInPath } from '../versionData'
-
 import generateStyle from './styles'
 import generateComponentTheme from './theme'
 import { LoadingScreen } from '../LoadingScreen'
@@ -126,7 +125,8 @@ class App extends Component<AppProps, AppState> {
       layout: 'large',
       docsData: null,
       versionsData: null,
-      iconsData: null
+      iconsData: null,
+      lightMode: true
     }
   }
 
@@ -734,7 +734,6 @@ class App extends Component<AppProps, AppState> {
       return <LoadingScreen />
     }
 
-    const lightMode = false
     const brandSvg = (
       <IconButton
         screenReaderLabel="Canvas Brand"
@@ -770,27 +769,27 @@ class App extends Component<AppProps, AppState> {
             boxSizing: 'border-box'
           }}
         >
-          <MobileTopNav brand={brandSvg} lightMode={lightMode}>
+          <MobileTopNav brand={brandSvg} lightMode={this.state.lightMode}>
             <MobileTopNav.BtnRow>
               <IconButton
                 withBackground={false}
                 withBorder={false}
                 screenReaderLabel="burgir"
-                color={lightMode ? 'secondary' : 'primary-inverse'}
+                color={this.state.lightMode ? 'secondary' : 'primary-inverse'}
               >
                 <IconAnalyticsLine />
               </IconButton>
               <IconButton
                 withBackground={false}
                 withBorder={false}
                 screenReaderLabel="burgir"
-                color={lightMode ? 'secondary' : 'primary-inverse'}
+                color={this.state.lightMode ? 'secondary' : 'primary-inverse'}
               >
                 <IconAlertsLine />
               </IconButton>
             </MobileTopNav.BtnRow>
             <MobileTopNav.BreadCrumb>
-              <Link href="#" isWithinText={false} color="link-inverse">
+              <Link href="#" isWithinText={false} color={this.state.lightMode ? 'link' : 'link-inverse'}>
                 <div
                   style={{ display: 'flex', alignItems: 'center', gap: '8px' }}
                 >
@@ -822,8 +821,28 @@ class App extends Component<AppProps, AppState> {
               >
                 Dashboard
               </MobileTopNav.Item>
+              <MobileTopNav.Item
+                rightIcon={<IconArrowOpenDownLine />}
+                onClick={() => alert('Simple option with no left icon')}
+              >
+                Simple option with no left icon
+              </MobileTopNav.Item>
             </MobileTopNav.ItemList>
           </MobileTopNav>
+          <div style={{ marginTop: '600px' }}>
+            <Checkbox
+              label="Light mode"
+              value="small"
+              variant="toggle"
+              size="large"
+              checked={this.state.lightMode}
+              onChange={(e) => {
+                this.setState((prevState) => {
+                  return { ...prevState, lightMode: !prevState.lightMode }
+                })
+              }}
+            />
+          </div>
           <p>
             1 Lorem ipsum dolor sit, amet consectetur adipisicing elit.
             Molestias excepturi a blanditiis, aspernatur repellat repellendus

diff --git a/packages/__docs__/src/App/props.ts b/packages/__docs__/src/App/props.ts
@@ -86,6 +86,7 @@ type AppState = {
   changelogData?: DocData
   // the currently shown document
   currentDocData?: DocData
+  lightMode: boolean
 }
 
 type DocData = ProcessedFile & {

diff --git a/packages/ui-top-nav-bar/src/MobileTopNav/styles.tsx b/packages/ui-top-nav-bar/src/MobileTopNav/styles.tsx
@@ -23,6 +23,7 @@
  */
 import type { MobileTopNavProps } from './props'
 
+//TODO use theme variables for spacing
 const generateStyles = (props: MobileTopNavProps, theme: any) => {
   const { lightMode } = props
   return {
@@ -36,7 +37,8 @@ const generateStyles = (props: MobileTopNavProps, theme: any) => {
         color: lightMode
           ? theme.colors.contrasts.grey125125
           : theme.colors?.contrasts?.white1010,
-        width: '100%'
+        width: '100%',
+        zIndex: '1000'
       }
     },
     topBar: {