fix(ui-tray): fix shouldCloseOnDocumentClick not working when a second Tray is opened
#1362
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerrTopi
approved these changes
Nov 10, 2023
|
Preview URL: https://1362--preview-instui.netlify.app |
joyenjoyer
approved these changes
Nov 15, 2023
balzss
commented
Nov 15, 2023
packages/ui-tray/src/Tray/README.md
Outdated
| constructor (props) { | ||
| super(props) | ||
| const FPO = lorem.paragraph(); | ||
| class ExampleLeft extends React.Component { |
There was a problem hiding this comment.
this shouldn't be included. was only for testing the changes
packages/__docs__/src/index.js
Outdated
| <App /> | ||
| </InstUISettingsProvider> | ||
| </React.StrictMode> | ||
| <InstUISettingsProvider theme={canvas}> |
There was a problem hiding this comment.
strick mode shouldn't be removed
balzss
force-pushed
the
fix/double-tray-open
branch
from
af371ed to
0ffc7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-3935