feat(ui-breadcrumb,ui-tooltip): add tooltips for truncated breadcrumbs #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes: INSTUI-4371
HerrTopi
force-pushed
the
INSTUI-4371-breadcrumb-tooltip
branch
from
8089b9c to
f88ed28
Compare
matyasf
requested changes
Nov 28, 2024
| * If true, it won't display the tooltip. This is useful in cases when tooltip is conditionally needed | ||
| * but in an uncontrolled way | ||
| */ | ||
| preventTooltip?: boolean |
There was a problem hiding this comment.
can you please write a test for this?
| <TruncateText | ||
| onUpdate={(isTruncated) => this.handleTruncation(isTruncated)} | ||
| > | ||
| <span aria-hidden={isTruncated}>{children}</span> |
There was a problem hiding this comment.
Saddly this is no good, NVDA ignores nodes that do not have text content or are set to aria-hidden. So here is just read 'button'
matyasf
reviewed
Nov 29, 2024
| isWithinText={false} | ||
| elementRef={this.handleRef} | ||
| > | ||
| <TruncateText |
There was a problem hiding this comment.
wouldnt it be easier just to use here native text truncation?
|
Let me know if you finish going through the requested changes and I will review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4371