Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): make tooltip border color overridable #1799

Conversation

igera93
Copy link
Contributor

@igera93 igera93 commented Nov 28, 2024

On this pr I added the border color as overrideable property.
CLX ticket for the change requirement: https://instructure.atlassian.net/browse/CLX-233
Figma design with the new border color: https://www.figma.com/design/HJj54DmmepY3EWhVb8AYZ5/CEC-Design-System?node-id=1024-9289&node-type=frame&m=dev

Updated view for the Tooltip component:
Screenshot 2024-11-28 at 15 14 15
Also I tried it out with red borders:
Screenshot 2024-11-28 at 14 56 24

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@igera93 igera93 requested review from balzss, matyasf, ke1k0 and a team November 28, 2024 14:15
Copy link

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-28 14:43 UTC

@matyasf matyasf self-assigned this Nov 28, 2024
@matyasf matyasf requested review from HerrTopi and removed request for ke1k0 November 28, 2024 14:27
@balzss
Copy link
Contributor

balzss commented Nov 28, 2024

Hi @igera93 , Thanks for the PR! You can achieve this override without any modification in our codebase with something like this:


<InstUISettingsProvider
      theme={{
        themeOverrides: {
            componentOverrides: {
              Popover: {
                borderColor: 'yellow',
              }
            }
          }
      }}
    >

    <Tooltip
      renderTip="Hello. I'm a tool tip"
      as={Button}
      onShowContent={() => console.log('showing')}
      onHideContent={() => console.log('hidden')}
    >
      Hover or focus me
    </Tooltip>
</InstUISettingsProvider>

@igera93
Copy link
Contributor Author

igera93 commented Nov 28, 2024

Hi @igera93 , Thanks for the PR! You can achieve this override without any modification in our codebase with something like this:


<InstUISettingsProvider
      theme={{
        themeOverrides: {
            componentOverrides: {
              Popover: {
                borderColor: 'yellow',
              }
            }
          }
      }}
    >

    <Tooltip
      renderTip="Hello. I'm a tool tip"
      as={Button}
      onShowContent={() => console.log('showing')}
      onHideContent={() => console.log('hidden')}
    >
      Hover or focus me
    </Tooltip>
</InstUISettingsProvider>

Oh nice, thanks for the heads up, at least I checked out the repo and tried out 😄 I will decline this pr 👍

@igera93 igera93 closed this Nov 28, 2024
@igera93 igera93 deleted the feat/CLX-233-tooltip-make-border-color-override-possible branch December 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants