Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more documentation on how to do theme overrides #1800

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Nov 28, 2024

Content mostly recovered from the deleted parts in the v9 version, but I also tried to make the examples more clear

@matyasf matyasf self-assigned this Nov 28, 2024
@matyasf matyasf requested review from HerrTopi and balzss November 28, 2024 15:53
Copy link

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1800/
on branch gh-pages at 2024-12-03 11:08 UTC

@balzss
Copy link
Contributor

balzss commented Nov 29, 2024

looks good, I'd add an extra section about overriding "nested" components. e.g. if you want to override the borderRadius for DateInput2 you cannot do it directly and you have to do it like this:

<InstUISettingsProvider
  theme={{
    componentOverrides: {
      TextInput: {
        borderRadius: '50%'
      }
    }
  }}
    >
    <DateInput2 />
</InstUISettingsProvider>

@matyasf matyasf merged commit 5f12cf0 into master Dec 3, 2024
8 checks passed
@matyasf matyasf deleted the more_theming_docs branch December 3, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants