Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(many): hide required asterisks from screenreaders #1803

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(many): hide required asterisks from screenreaders #1803

merged 1 commit into from
Dec 3, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Nov 29, 2024

INSTUI-4374

also fixed 2 instances where the wrong color token was used

test plan:

  • check if screen readers ignore the required asterisk in field labels

@balzss balzss requested review from matyasf and HerrTopi November 29, 2024 14:49
@balzss balzss self-assigned this Nov 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 11:26 UTC

@balzss balzss merged commit 78aec71 into master Dec 3, 2024
11 checks passed
@balzss balzss deleted the fix/aria-hidden-required-asterisk branch December 3, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerrTopi HerrTopi HerrTopi approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balzss @matyasf @HerrTopi