Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-progress): add isRounded to ProgressBar #1805

Closed
wants to merge 1 commit into from

Conversation

adamiku
Copy link
Contributor

@adamiku adamiku commented Dec 2, 2024

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Dec 2, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 10:10 UTC

@adamiku adamiku marked this pull request as ready for review December 2, 2024 13:36
@balzss
Copy link
Contributor

balzss commented Dec 3, 2024

Hi @adamiku , thanks for the PR. Please do not add isRounded as a prop but add a new theme variable for borderRadius in progressbar instead so you can override it with your value (20px) in your codebase. Also we do not use hardcoded variables in styles.ts files.

@adamiku
Copy link
Contributor Author

adamiku commented Dec 3, 2024

Hi @adamiku , thanks for the PR. Please do not add isRounded as a prop but add a new theme variable for borderRadius in progressbar instead so you can override it with your value (20px) in your codebase. Also we do not use hardcoded variables in styles.ts files.

I close this PR as the InstUi team will implement it.

@adamiku adamiku closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants