-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-types,ui-progress): add customization options for progressbar #1808
Conversation
b45639c
to
2301453
Compare
|
<span css={styles?.trackValue}>{renderValueInside && value}</span> | ||
</span> | ||
</span> | ||
|
||
{value && ( | ||
{value && !renderValueInside && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to write a test for this? e.g if renderValueInside is true
then the value text should be inside the track's DOM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the API, tested it with SR too, it works, an extra unit test would be nice
2301453
to
f993371
Compare
Looks good to me! Thanks! |
INSTUI-4390
test plan: