Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-types,ui-progress): add customization options for progressbar #1808

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Dec 3, 2024

INSTUI-4390

test plan:

  <ProgressBar
    themeOverride={{
      borderRadius: '20px'
    }}
    size="large"
    screenReaderLabel="Progressbar"
    valueNow={40}
    valueMax={100}
    renderValueInside
    renderValue={
      <span style={{display: 'flex', justifyContent: 'end', alignItems: 'center', height: '100%', paddingRight: '12px', fontWeight: 'bold', color: 'white'}}>
        40%
      </span>
    }
  />

@balzss balzss self-assigned this Dec 3, 2024
@balzss balzss force-pushed the feat/progressbar-customization branch from b45639c to 2301453 Compare December 3, 2024 13:43
Copy link

github-actions bot commented Dec 3, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-06 15:50 UTC

@balzss balzss requested review from HerrTopi and matyasf December 3, 2024 15:50
@balzss balzss marked this pull request as ready for review December 3, 2024 15:50
@balzss balzss requested a review from a team December 4, 2024 09:57
Comment on lines +134 to +138
<span css={styles?.trackValue}>{renderValueInside && value}</span>
</span>
</span>

{value && (
{value && !renderValueInside && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to write a test for this? e.g if renderValueInside is true then the value text should be inside the track's DOM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the API, tested it with SR too, it works, an extra unit test would be nice

@balzss balzss force-pushed the feat/progressbar-customization branch from 2301453 to f993371 Compare December 5, 2024 11:24
@balzss balzss requested a review from matyasf December 5, 2024 12:29
@adamiku
Copy link
Contributor

adamiku commented Dec 6, 2024

Looks good to me! Thanks!

@balzss balzss merged commit 56308de into master Dec 6, 2024
11 checks passed
@balzss balzss deleted the feat/progressbar-customization branch December 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants