Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add expanded state to menu side navigation button #1811

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore: add expanded state to menu side navigation button #1811

merged 1 commit into from
Dec 9, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Dec 5, 2024 •
edited
Loading

Closes: INSTUI-4249

ISSUE:

  • the side navigation button is not announced as "expanded" when it is open.

TEST PLAN:

  • click on the side navigation button in the documentation to open it
  • the screen reader should announce it as "expanded" after the menu opens.

@ToMESSKa ToMESSKa self-assigned this Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-09 10:47 UTC

@ToMESSKa ToMESSKa requested review from matyasf and balzss December 5, 2024 13:32
@ToMESSKa ToMESSKa merged commit af4c237 into master Dec 9, 2024
11 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4249_docs_announce_the_state_of_the_open_close_sidebar_button branch December 9, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balzss balzss balzss approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToMESSKa @matyasf @balzss