refactor: upgrade dependencies #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyasf
commented
Dec 9, 2024
| * Reads a package.json | ||
| * @param options {readPkgUp.NormalizeOptions} | ||
| * @returns {readPkgUp.NormalizedPackageJson} | ||
| */ |
There was a problem hiding this comment.
new version of TS complains about not able to infer types if this comment is not here
matyasf
commented
Dec 9, 2024
| // eslint-disable-next-line no-console | ||
| console.log('Icon font generated:', result) | ||
| .then((_result) => { | ||
| //console.log('Icon font generated:', result) |
There was a problem hiding this comment.
This is generating the 'icon created' spam on the beginning of npm run boorstrap I've turned this off since its generating like 5000 line of logs
|
joyenjoyer
approved these changes
Dec 10, 2024
matyasf
commented
Dec 10, 2024
Comment on lines
+37
to
42
| for (let x = 0; x < 500; x++) { | ||
| const id = uid('', 17) | ||
| results.add(id) | ||
| } | ||
| expect(results.size).toBe(5000) | ||
| expect(results.size).toBe(500) | ||
| }) |
There was a problem hiding this comment.
The original test was failing quite often simply because of probability, now generating 2 similar IDs and the test failing should happen much much less often
git-nandor
approved these changes
Dec 11, 2024
Closes: INSTUI-4218 The test was failing because it relied on a random probability which was happening too often
matyasf
force-pushed
the
upgrade_deps
branch
from
b302841 to
79990b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just smaller dependency updates and related minor fixes