feat(ui-number-input): add renderIcons prop #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HerrTopi
reviewed
Dec 10, 2024
| @@ -226,7 +234,11 @@ const propTypes: PropValidators<PropKeys> = { | |||
| onKeyDown: PropTypes.func, | |||
| inputMode: PropTypes.oneOf(['numeric', 'decimal', 'tel']), | |||
| textAlign: PropTypes.oneOf(['start', 'center']), | |||
| allowStringValue: PropTypes.bool | |||
| allowStringValue: PropTypes.bool, | |||
| renderIcons: PropTypes.shape({ | |||
There was a problem hiding this comment.
Please add the "renderIcons" prop to the allowedProps list as well (see below in the code)
| @@ -166,6 +166,14 @@ type NumberInputOwnProps = { | |||
| * sets the input type to string and allows string as value | |||
| */ | |||
| allowStringValue?: boolean | |||
|
|
|||
| /** | |||
| * Definition of the icons to be rendered for increase and decrease buttons | |||
There was a problem hiding this comment.
Kinda nitpicky: Since this text acts as the documentation for the prop on the insUI docs page, I would rephrase it to something like this:
"Sets the icons to be rendered for increase and decrease buttons"
…ment buttons Closes: CLX-261
szalonna
force-pushed
the
feature/CLX-261-numberinput-custom-icons
branch
from
6fa4037 to
df2fc56
Compare
ToMESSKa
approved these changes
Dec 11, 2024
matyasf
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CLX-261
Add
renderIconsprop to make the increase/decrease buttons customizable with externally defined iconsTEST PLAN:
Chromatic test for rendered icons and unit test to ensure unchanged behaviour