feat(ui-tabs): extends the customization of Tab component #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: CLX-276 Adds the possibility to disable built-in styling of a `Tab` to replace with a custom component through `renderTitle` - adds `customTab` flag to `Panel` to remove the default styling from the `Tab` - adds `alignTab` prop to `Panel` to allow to customzie the `Tabs`'s relative alignment in the container flexbox
|
|
thanks for the PR @szalonna! this is an OK solution but I think it would be more in line with our ways of doing custom styling if instead of adding these new props, you would introduce new theme variables (e.g. for alignment) so it could be done with themeoverrides. what do you think @matyasf @HerrTopi ? |
|
@szalonna or you might not need any changes at all, please check this example to see if this level of customization is enough for your usecase: https://codesandbox.io/p/sandbox/broken-monad-hz83k4?file=%2Findex.js%3A28%2C29-28%2C40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CLX-276
Adds the possibility to disable built-in styling of a
Tabto replace with a custom component throughrenderTitlecustomTabflag toPanelto remove the default styling from theTabalignTabprop toPanelto allow to customzie theTabs's relative alignment in the container flexbox