fix(ui-date-time-input): fix DateTimeInput displaying wrong value of its value is changed in a onChange callback #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its value is changed in a onChange callback Closes: INSTUI-4406 I could only repropduce it in CodeSandbox, but according to React documentation setState is not synchronous so the results are not deterministic TEST PLAN: Make a DateTimeInput whose value changes in an onChange listerer on CodeSandbox. It should update properly
|
balzss
approved these changes
Dec 17, 2024
matyasf
added a commit
that referenced
this pull request
Dec 19, 2024
…its value is changed in a onChange callback Closes: INSTUI-4406 I could only repropduce it in CodeSandbox, but according to React documentation setState is not deterministic. Backport of PR #1829 from InstUI v10 TEST PLAN: Make a DateTimeInput whose value changes in an onChange listerer on CodeSandbox. It should update properly
matyasf
added a commit
that referenced
this pull request
Dec 19, 2024
…its value is changed in a onChange callback Closes: INSTUI-4406 I could only repropduce it in CodeSandbox, but according to React documentation setState is not deterministic. Backport of PR #1829 from InstUI v10 TEST PLAN: Make a DateTimeInput whose value changes in an onChange listerer on CodeSandbox. It should update properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4406
I could only reproduce it in CodeSandbox, but according to React documentation setState is not synchronous so the results are not deterministic.
TEST PLAN:
Enter '2' to the date input here: https://codesandbox.io/p/sandbox/stupefied-almeida-d8qxtr observe that the DateTimeInput's message field displays the correct date.
Change the dependency to InstUI 10.9.0, reload the preview and do the same. DateTimeInput's value should be wrong