Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS capture device discovery support for old systems #76

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Jan 26, 2024

Synopsis

While fixing instrumentisto/medea-flutter-webrtc#147 it was discovered that libwebrtc also uses new MacOS API which crashes application on old MacOS systems. So we need to fix this here too.

Solution

Add a patch which works similarly to the approach used in the instrumentisto/flutter-webrtc. In other words just use old API on old systems and new API on new systems.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added the enhancement New feature or request label Jan 26, 2024
@evdokimovs evdokimovs self-assigned this Jan 26, 2024
@evdokimovs
Copy link
Author

FCM

MacOS capture device discovery support for old systems (#76)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant