Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recorder::Builder::build(), recorder::Builder::build_freezable() and recorder::Builder::build_frozen() methods #4

Merged
merged 7 commits into from
Jan 24, 2023

Conversation

ilslv
Copy link
Contributor

@ilslv ilslv commented Jan 24, 2023

Synopsis

To be able to compose Recorders, we need build_*() methods in addition to build_*_and_install().

Solution

Add build_*() methods in addition to build_*_and_install().

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@ilslv ilslv added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Jan 24, 2023
@ilslv ilslv added this to the 0.3.1 milestone Jan 24, 2023
@ilslv ilslv self-assigned this Jan 24, 2023
@ilslv
Copy link
Contributor Author

ilslv commented Jan 24, 2023

FCM

Add `recorder::Builder::build()`, `recorder::Builder::build_freezable()` and `recorder::Builder::build_frozen()` methods (#4)

@ilslv ilslv changed the title Build methods Add recorder::Builder::build(), recorder::Builder::build_freezable() and recorder::Builder::build_frozen() methods Jan 24, 2023
@ilslv ilslv requested a review from tyranron January 24, 2023 13:50
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv nice job, thanks! 👍

@tyranron tyranron added feature New feature or request semver::feature New feature in terms of SemVer and removed enhancement Improvement of existing features or bugfix labels Jan 24, 2023
@tyranron tyranron merged commit c2e0e73 into main Jan 24, 2023
@tyranron tyranron deleted the build-methods branch January 24, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request k::api Related to API (application interface) semver::feature New feature in terms of SemVer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants