Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometry copier #737

Merged
merged 39 commits into from
Nov 15, 2024
Merged

Photometry copier #737

merged 39 commits into from
Nov 15, 2024

Conversation

oliche
Copy link
Member

@oliche oliche commented Nov 11, 2024

The photometry copier has a prototype.

A few questions still:

  • I chose to validate thoroughly the neurophotometrics CSV using pandera this is a new dependency... I think this is worthwhile, but let me know if you have reservation and I can shelve the validation part
  • the code to validate and read the csv is currently in iblrig, it may be useful to move it to ibl-photometry. But that means we will have to groom and prepare ibl-photometry as an iblrig dependency. This also means we get pynapple in our environment.

This would usually be a draft pull request, but here I see no harm in merging early as there isn't much impact on the other code.

@grg2rsr grg2rsr self-assigned this Nov 11, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Coverage Status

Changes unknown
when pulling 3d8eaa5 on photometry
into ** on iblrigv8dev**.

@grg2rsr grg2rsr removed their assignment Nov 13, 2024
@bimac bimac changed the base branch from iblrigv8 to iblrigv8dev November 15, 2024 15:21
@bimac bimac merged commit 79d9084 into iblrigv8dev Nov 15, 2024
7 checks passed
@bimac bimac deleted the photometry branch November 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants