Add OTP support to grant-type password #1174
Conversation
|
Hi @jsalatiel, not a maintainer here but was just looking for a way to do OTP with Kubelogin. I saw you forked it and implemented your own version. Would it make sense for you to fix the failing tests in the PR and then we can ping the maintainer to have a look at it? I'd love to have OTP support from this repo! 💯 |
|
I will see what i can do. |
|
If you need any support on it don't hesitate to ping here, otherwise thank you so much :) |
|
@jsalatiel is it possible to move this? |
| ctx = c.wrapContext(ctx) | ||
| token, err := c.oauth2Config.PasswordCredentialsToken(ctx, username, password) | ||
| token, err := c.oauth2Config.PasswordCredentialsToken(ctx, username, password, otp) |
There was a problem hiding this comment.
It seems that https://pkg.go.dev/github.com/golang/oauth2#Config.PasswordCredentialsToken does not accept the 4th argument.
I could not find any description of OTP in the Resource Owner Password Credentials Grant. Is it possible to send the OTP parameter in the token request?
Add support to ask for a OTP if the grant-type is set to password.