v2.1.0 minor release (#52)

* Handle large Http responses with fetch
* Remove AbstractApPayment class, not needed
* Fix minor defects and update unit tests
* Dependency updates

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intacct/intacct-sdk",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "Sage Intacct SDK for JavaScript",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -40,7 +40,7 @@
     "doc": "rimraf doc && typedoc src/",
     "pretest": "npm run build",
     "test": "npm run tslint && npm run test-mocha",
-    "test-mocha": "mocha -require ts-node/register test/**/*.ts",
+    "test-mocha": "mocha -require ts-node/register \"test/**/*.ts\"",
     "coverage": "nyc npm run test",
     "preversion": "npm test",
     "version": "npm run build",
@@ -55,7 +55,6 @@
     "@types/mock-fs": "^4.13.0",
     "@types/node": "^14.14.14",
     "@types/uuid": "^8.3.0",
-    "@types/winston": "^2.4.4",
     "@types/xml2js": "^0.4.7",
     "@types/xmlbuilder": "^0.0.32",
     "chai": "~4.2.0",
@@ -72,7 +71,7 @@
   },
   "dependencies": {
     "content-type": "^1.0.4",
-    "dateformat": "^4.3.1",
+    "dateformat": "^4.4.1",
     "ini": "^1.3.8",
     "node-fetch": "^2.6.1",
     "striptags": "^3.1.1",

src/Functions/AccountsPayable/ApPaymentConfirm.ts

@@ -24,7 +24,7 @@ export default class ApPaymentConfirm extends AbstractApPaymentFunction {
         super(recordNo, controlId);
     }
 
-protected getFunction(): string {
+    protected getFunction(): string {
         return AbstractApPaymentFunction.CONFIRM;
     }
 }

src/Functions/AccountsPayable/ApPaymentCreate.ts

@@ -29,6 +29,7 @@ export default class ApPaymentCreate extends AbstractFunction {
         super(controlId);
         this.apPaymentInfo = apPaymentInfo;
     }
+
     public writeXml(xml: IaXmlWriter): void {
         xml.writeStartElement("function");
         xml.writeAttribute("controlid", this.controlId, true);

src/Functions/AccountsPayable/ApPaymentDetailBill.ts

@@ -29,8 +29,6 @@ export default class ApPaymentDetailBill implements IApPaymentDetail {
     }
 
     public writeXml(xml: IaXmlWriter): void {
-    {
-
         xml.writeStartElement("APPYMTDETAIL");
 
         xml.writeElement("RECORDKEY", this.info.recordNo, true);
@@ -53,4 +51,3 @@ export default class ApPaymentDetailBill implements IApPaymentDetail {
         xml.writeEndElement(); // APPYMTDETAIL
     }
 }
-}

src/Functions/AccountsPayable/index.ts

@@ -1,7 +1,6 @@
 export { default as AbstractApAdjustment } from "./AbstractApAdjustment";
 export { default as AbstractApAdjustmentLine } from "./AbstractApAdjustmentLine";
 export { default as AbstractApAdjustmentSummary } from "./AbstractApAdjustmentSummary";
-export { default as AbstractApPayment } from "./AbstractApPayment";
 export { default as AbstractApPaymentDetailCredit } from "./AbstractApPaymentDetailCredit";
 export { default as AbstractApPaymentFunction } from "./AbstractApPaymentFunction";
 export { default as AbstractBill } from "./AbstractBill";

src/Functions/Common/Query/Comparison/InArray/InArrayInteger.ts

@@ -26,7 +26,7 @@ export default class InArrayInteger extends AbstractArrayInteger {
         let notClause = "";
 
         if (this.negate === true) {
-            notClause = "NOT ";
+            notClause = " NOT";
         }
 
         clause = this.field + notClause + " IN (" + this.valuesList.join(",") + ")";

src/Functions/Common/Query/Comparison/InArray/InArrayString.ts

@@ -26,7 +26,7 @@ export default class InArrayString extends AbstractArrayString {
         let notClause = "";
 
         if (this.negate === true) {
-            notClause = "NOT ";
+            notClause = " NOT";
         }
 
         const pieces = [];

src/Functions/Purchasing/PurchasingTransactionApprove.ts

@@ -30,9 +30,9 @@ export default class PurchasingTransactionApprove extends AbstractPurchasingTran
 
         xml.writeStartElement("PODOCUMENT");
 
-        xml.writeElement("DOCID", External);
+        xml.writeElement("DOCID", this.externalId);
 
-        xml.writeElement("COMMENT", Comment);
+        xml.writeElement("COMMENT", this.comment);
 
         xml.writeEndElement(); // PODOCUMENT
 

src/Functions/Purchasing/PurchasingTransactionDecline.ts

@@ -30,9 +30,9 @@ export default class PurchasingTransactionDecline extends AbstractPurchasingTran
 
         xml.writeStartElement("PODOCUMENT");
 
-        xml.writeElement("DOCID", External);
+        xml.writeElement("DOCID", this.externalId);
 
-        xml.writeElement("COMMENT", Comment);
+        xml.writeElement("COMMENT", this.comment);
 
         xml.writeEndElement(); // PODOCUMENT
 

src/Xml/HttpClientHandler.ts

@@ -27,7 +27,14 @@ export default class HttpClientHandler {
         this.options = options;
     }
 
-    public async postAsync(): Promise<Response> {
-        return await fetch(this.options.url, this.options);
+    public async postAsync(): Promise<[Response, string]> {
+        try {
+            const response = await fetch(this.options.url, this.options);
+            const body = await response.text();
+
+            return Promise.all([response, body]);
+        } catch (error) {
+            throw new Error(error);
+        }
     }
 }

src/Xml/IaXmlWriter.ts

@@ -100,10 +100,10 @@ export default class IaXmlWriter {
         } else {
             if (value == null) {
                 if (writeNull === true) {
-                    this._writer.element(localName, value).up();
+                    this._writer.element(localName, "").up();
                 }
             } else {
-                this._writer.element(localName, value).up();
+                this._writer.element(localName, "").up();
             }
         }
     }

src/Xml/LoggingHandler.ts

@@ -35,21 +35,18 @@ export default class LoggingHandler extends HttpClientHandler {
         this.logLevel = logLevel;
     }
 
-    public async postAsync(): Promise<Response> {
-        let response;
+    public async postAsync(): Promise<[Response, string]> {
+
         try {
             this.logger.log(this.logLevel, this.logMessageFormatter.formatRequest(this.options));
-
-            response = await super.postAsync();
-
-            this.logger.log(this.logLevel,
-                    this.logMessageFormatter.formatResponse(response,
-                        await response.clone().text()));
-
+            return await super.postAsync().then(([response, body]) => {
+                this.logger.log(this.logLevel,
+                    this.logMessageFormatter.formatResponse(response, body));
+                return Promise.all([response, body]);
+            });
         } catch (error) {
             this.logger.log(this.logLevel, error);
             throw error;
         }
-        return response;
     }
 }

src/Xml/RequestHandler.ts

@@ -61,9 +61,10 @@ export default class RequestHandler {
         }
 
         const request = new RequestBlock(this.clientConfig, this.requestConfig, content);
-        const response = await this.execute(request.writeXml());
 
-        return new OnlineResponse(await response.clone().text());
+        return await this.execute(request.writeXml()).then((body) => {
+            return new OnlineResponse(body);
+        });
     }
 
     public async executeOffline(content: IFunction[]): Promise<OfflineResponse> {
@@ -83,9 +84,9 @@ export default class RequestHandler {
         }
 
         const request = new RequestBlock(this.clientConfig, this.requestConfig, content);
-        const response = await this.execute(request.writeXml());
-
-        return new OfflineResponse(await response.clone().text());
+        return await this.execute(request.writeXml()).then((body) => {
+            return new OfflineResponse(body);
+        });
     }
 
     private getHttpClient(options: object): HttpClientHandler {
@@ -101,7 +102,7 @@ export default class RequestHandler {
         }
     }
 
-    private async execute(xml: string): Promise<Response> {
+    private async execute(xml: string): Promise<string> {
         const httpClient = this.getHttpClient({
             url: this.endpointUrl,
             method: "POST",
@@ -115,6 +116,7 @@ export default class RequestHandler {
                 "Accept-Encoding": "gzip",
                 "User-Agent": "intacct-sdk-js-client/" + this.version,
             },
+            size: 0,
         });
 
         for (let attempt = 0; attempt <= this.requestConfig.maxRetries; attempt++) {
@@ -123,28 +125,29 @@ export default class RequestHandler {
                 await this.exponentialDelay(attempt);
             }
 
-            const response = await httpClient.postAsync();
+            const result = await httpClient.postAsync();
+            const response = result[0];
+            const body = result[1];
 
             let ok = true;
             if (response.status >= 400 && response.status < 600) {
                 ok = false;
             }
             if (ok === true) {
-                return response;
+                return body;
             } else if (this.requestConfig.noRetryServerErrorCodes.indexOf(response.status) !== -1) {
                 // Do not retry this explicitly set 500 level server error
-                throw new FetchError(response.status, response.text(), httpClient.options, response);
+                throw new FetchError(response.status, body, httpClient.options, response);
             } else if (response.status >= 500 && response.status <= 599) {
                 // Retry 500 level server errors
                 continue;
             } else {
                 const contentTypeObj = contentType.parse(response.headers.get("content-type"));
                 const mimeType = contentTypeObj.type;
                 if (mimeType === "text/xml" || mimeType === "application/xml") {
-                    return response;
+                    return body;
                 }
-
-                throw new FetchError(response.status, response.text(), httpClient.options, response);
+                throw new FetchError(response.status, body, httpClient.options, response);
             }
         }
         throw new Error("Request retry count exceeded max retry count: " + this.requestConfig.maxRetries.toString());

test/Functions/AccountsReceivable/ArPaymentCreateTest.ts

@@ -110,38 +110,6 @@ describe("ArPaymentCreate", () => {
             applyToRecordB,
         ];
 
-        XmlObjectTestHelper.CompareXml(expected, record);
-    });
-    it("should generate XML to Create Payment against invoice header", () => {
-        const expected = `<?xml version="1.0" encoding="utf-8" ?>
-<test>
-    <function controlid="unittest">
-        <create>
-            <ARPYMT>
-                <FINANCIALENTITY>BOA</FINANCIALENTITY>
-                <PAYMENTMETHOD>Cash</PAYMENTMETHOD>
-                <CUSTOMERID>JHC</CUSTOMERID>
-                <DOCNUMBER>INV-007</DOCNUMBER>
-                <RECEIPTDATE>05/15/2019</RECEIPTDATE>
-                <PAYMENTDATE>05/16/2019</PAYMENTDATE>
-                <ARPYMTDETAILS>
-                    <ARPYMTDETAIL>
-                        <RECORDKEY>101</RECORDKEY>
-                        <TRX_PAYMENTAMOUNT>125</TRX_PAYMENTAMOUNT>
-                    </ARPYMTDETAIL>
-                </ARPYMTDETAILS>
-            </ARPYMT>
-        </create>
-    </function>
-</test>`;
-
-        const record = new ArPaymentCreate();
-        record.controlId = "unittest";
-        record.customerId = "C0020";
-        record.transactionPaymentAmount = 1922.12;
-        record.receivedDate = new Date("6/30/2016");
-        record.paymentMethod = "Printed Check";
-
         XmlObjectTestHelper.CompareXml(expected, record);
     });
 });

test/Functions/Common/NewQuery/QueryFilter/AndOperatorTest.ts

@@ -78,7 +78,7 @@ describe("AndOperator", () => {
             () => {
                 const xml = new IaXmlWriter(xmlbuilder.create("request", {
                     "version": "1.0",
-                    "encoding": this.encoding,
+                    "encoding": "utf-8",
                     "standalone": null,
                 }));
                 const filter = (new AndOperator(
@@ -98,7 +98,7 @@ describe("AndOperator", () => {
             () => {
                 const xml = new IaXmlWriter(xmlbuilder.create("request", {
                     "version": "1.0",
-                    "encoding": this.encoding,
+                    "encoding": "utf-8",
                     "standalone": null,
                 }));
                 const filter = new AndOperator([]);
@@ -114,7 +114,7 @@ describe("AndOperator", () => {
             () => {
                 const xml = new IaXmlWriter(xmlbuilder.create("request", {
                     "version": "1.0",
-                    "encoding": this.encoding,
+                    "encoding": "utf-8",
                     "standalone": null,
                 }));
                 const filter = new AndOperator(null);
@@ -165,7 +165,7 @@ describe("AndOperator", () => {
             () => {
                 const xml = new IaXmlWriter(xmlbuilder.create("request", {
                     "version": "1.0",
-                    "encoding": this.encoding,
+                    "encoding": "utf-8",
                     "standalone": null,
                 }));
                 const filter = new AndOperator();