Modify the check_results.py to support batch 2&4 #11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkvision
reviewed
May 31, 2024
Comment on lines
10
to
11
| batch_size: 1 # default to 1 | ||
| batch_size: | ||
| - 1 # default to 1 |
| @@ -23,7 +23,8 @@ warm_up: 1 | |||
| num_trials: 3 | |||
| num_beams: 1 # default to greedy search | |||
| low_bit: 'sym_int4' # default to use 'sym_int4' (i.e. symmetric int4) | |||
| batch_size: 1 # default to 1 | |||
| batch_size: # default to 1 | |||
| @@ -9,11 +9,13 @@ warm_up: 1 | |||
| num_trials: 3 | |||
| num_beams: 1 # default to greedy search | |||
| low_bit: 'sym_int4' # default to use 'sym_int4' (i.e. symmetric int4) | |||
| batch_size: 1 # default to 1 | |||
| batch_size: # default to 1 | |||
| current_csv_model_input_2nd=current_csv_model+'-'+current_csv_input_output_pairs+'-'+'2nd' | ||
| add_to_dict(csv_dict, current_csv_model_input_1st, current_csv_row[latency_1st_token]) | ||
| add_to_dict(csv_dict, current_csv_model_input_2nd, current_csv_row[latency_2_avg]) | ||
| try: |
There was a problem hiding this comment.
under what case this try will fail?
hkvision
reviewed
May 31, 2024
| for batch_size in conf["batch_size"]: | ||
| global csv_name | ||
| batch = str(batch_size) | ||
| csv_name = f'{current_dir}/test_batch{batch}/{api}-results-{today}-batch-{batch}.csv' |
There was a problem hiding this comment.
better not add a folder in this file.
hkvision
reviewed
Jun 3, 2024
Comment on lines
1826
to
1827
| batch = str(conf["batch_size"]) | ||
| csv_name = f'{current_dir}/{api}-results-{today}-batch-{batch}.csv' # mwj don't add directly / change the directory |
There was a problem hiding this comment.
do not modify the csv name
Support multiple batch in one config
hkvision
reviewed
Jun 3, 2024
| @@ -17,3 +17,4 @@ in_out_pairs: | |||
| test_api: | |||
| - "transformer_int4_gpu" # on Intel GPU | |||
| cpu_embedding: False # whether put embedding to CPU (only avaiable now for gpu win related test_api) | |||
| exclude: | |||
There was a problem hiding this comment.
revert this if no exclude?
hkvision
reviewed
Jun 3, 2024
Comment on lines
35
to
36
| - 'baichuan-inc/Baichuan2-13B-Chat-4bit:2048:1' | ||
| - 'bigscience/bloomz-7b1:2048:1' |
There was a problem hiding this comment.
revert this? make run.py compatible with the original yaml.
hkvision
reviewed
Jun 3, 2024
Comment on lines
108
to
109
| except NameError: | ||
| pass |
hkvision
reviewed
Jun 3, 2024
| cd ../../../../../ | ||
| cp python/llm/test/benchmark/arc-perf-test-batch2.yaml python/llm/dev/benchmark/all-in-one/config.yaml | ||
| cd python/llm/dev/benchmark/all-in-one | ||
| # changr csv name |
| @@ -36,3 +36,4 @@ exclude: | |||
| # - 'fnlp/moss-moon-003-sft-4bit:2048' | |||
| - 'baichuan-inc/Baichuan2-13B-Chat-4bit:2048' | |||
| - 'bigscience/bloomz-7b1:2048' | |||
|
|
|||
hkvision
approved these changes
Jun 3, 2024
hkvision
reviewed
Jun 5, 2024
| else: | ||
| batch_list = conf["batch_size"] | ||
| for batch_size in batch_list: | ||
| csv_name = f'{current_dir}/{api}-results-{today}.csv' |
There was a problem hiding this comment.
put this out of the for loop?
hkvision
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the check_results.py. Counting batch_size when checking the total test cases. Also comment the 'batch_szie == 4' exclude cases to support the checking-result process.