Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update minicpm.py #11517

Merged
merged 2 commits into from
Jul 5, 2024
Merged

update minicpm.py #11517

merged 2 commits into from
Jul 5, 2024

Conversation

qiuxin2012
Copy link
Contributor

@qiuxin2012 qiuxin2012 commented Jul 5, 2024 •
edited
Loading

Description

update minicpm.py

  1. Use sdp for the first attention, optimize Minicpm #11189 (comment) is fixed now.
  2. Use rotary_half_inplaced instead of apply_rotary_pos_emb_no_cache_xpu

@qiuxin2012
Copy link
Contributor Author

https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/9804303774

@qiuxin2012 qiuxin2012 merged commit a31f2cb into intel-analytics:main Jul 5, 2024
1 check passed
RyuKosei pushed a commit to RyuKosei/ipex-llm that referenced this pull request Jul 19, 2024
@qiuxin2012 @MeouSker77
update minicpm.py (intel-analytics#11517)
f2b545f 
* update minicpm

* meet code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeouSker77 MeouSker77 MeouSker77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiuxin2012 @MeouSker77