Support pipeline parallel for glm-4v #11545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plusbang
changed the title
xiangyuT
reviewed
Jul 11, 2024
| inputs_embeds = self.embedding(input_ids) | ||
| else: | ||
| batch_size, seq_length, _ = inputs_embeds.shape |
There was a problem hiding this comment.
input_ids is needed for self.get_masks(). Maybe add an empty tensor here (similar to chatglm2/4)
There was a problem hiding this comment.
input_idsis needed forself.get_masks(). Maybe add an empty tensor here (similar to chatglm2/4)
Have updated :)
RyuKosei
pushed a commit
to RyuKosei/ipex-llm
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support pipeline parallel for glm-4v and provide related example.
TODO: may use the common python script for qwen-vl and glm-4v
3. Summary of the change
pipeline_parallel_generate4. How to test?
1234). And paste your action link here once it has been successfully finished.https://github.com/intel-analytics/ipex-llm-workflow/actions/runs/9886498874