LLM: unify memory optimization env variables. #11549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkvision
reviewed
Jul 10, 2024
Comment on lines
335
to
336
| else: | ||
| optimize_lm_head = False |
There was a problem hiding this comment.
no need this? default to be false in Line 327?
qiyuangong
reviewed
Jul 10, 2024
| if os.environ.get("IPEX_LLM_LAST_LM_HEAD", None) is not None: | ||
| optimize_lm_head = os.environ.get("IPEX_LLM_LAST_LM_HEAD", None) == "1" | ||
| elif os.environ.get("IPEX_LLM_LOW_MEM", None) is not None: | ||
| optimize_lm_head = os.environ.get("IPEX_LLM_LOW_MEM", None) == "1" |
There was a problem hiding this comment.
We should disable optimize_lm_head when using speculative or lookahead.
There was a problem hiding this comment.
We already have conditions to avoid impacting speculative . But magic value 10 maybe not a good value. in
ipex-llm/python/llm/src/ipex_llm/transformers/low_bit_linear.py
Lines 343 to 346 in 51f2eff
RyuKosei
pushed a commit
to RyuKosei/ipex-llm
that referenced
this pull request
Jul 19, 2024
* LLM: unify memory optimization env variables. * fix comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to unify memory optimization env variables to
IPEX_LLM_LOW_MEMfor users to easily enable memory optimizations. We also keepIPEX_LLM_LAST_LM_HEADandIPEX_LLM_SPLIT_QKVfor compatibility and disabling the specific optimization for some situations.