Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all ipex usage #12666

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

MeouSker77
Copy link
Contributor

Description

Remove all remaining ipex usage

  • remove gptj optimization to remove ipex usage. Its optimization is out of date, we could rewrite new optimization if it is needed again in the future
  • remove FP16Linear's transposed linear matmul, it has no performance improvement since 2.3

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

@MeouSker77
Copy link
Contributor Author

@@ -852,7 +838,7 @@ def use_esimd_kernel(self, x):
if self.disable_fp16_opt:
return False
# esimd kernel can only be used for Arc and Flex
if gpu_type not in ["arc", "flex"]:
if gpu_type not in ["arc"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove flex here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex is now recognized as "arc", no need to handle it any more

Copy link
Contributor

@Oscilloscope98 Oscilloscope98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MeouSker77 MeouSker77 merged commit ccf618f into intel-analytics:main Jan 8, 2025
1 check passed
@MeouSker77 MeouSker77 deleted the remove-all-ipex-usage branch January 8, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants