Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

[HDR & WCG patch1] Fix videolayer render issues #663

Open
wants to merge 1 commit into
base: hdr_invest
Choose a base branch
from
Open

[HDR & WCG patch1] Fix videolayer render issues #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ testlayers_SOURCES = \
./common/layerrenderer.cpp \
./common/gllayerrenderer.cpp \
./common/glcubelayerrenderer.cpp \
./common/videolayerrenderer.cpp \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change supposed to be part of another pull request? Suggest combining it with the corresponding commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are a couple of patches need to be reviewed in parallel and there are some commit order dependence among them. The list of PRs for these patches have been committed into my own git repo:
https://github.com/shuangwan01/IA-Hardware-Composer/pulls

Not sure if there is an efficient way to push PRs into this project directly and manage the further revisions accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to combine the patches under one commit? The specific commit order requirement may be difficult to maintain because only the author and reviewers are familiar with it right? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree with you that one commit will make the PR maintenance more easier. But this feature is involving 3 authors and feature itself even doesn't have tested under Android. So it's expected large number of revisions according to real tests/debugs and review comments. Breaking down into small code pieces will make this practice more efficient and is also easier for community to conduct code review :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds appropriate :) 👍

./common/esTransform.cpp \
./common/jsonhandlers.cpp \
./apps/jsonlayerstest.cpp
Expand Down
1 change: 0 additions & 1 deletion tests/apps/jsonlayerstest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,6 @@ static void init_frames(int32_t width, int32_t height) {
printf("un-recognized layer type!\n");
exit(-1);
}

if (!renderer->Init(layer_parameter.source_width,
layer_parameter.source_height, gbm_format,
usage_format, usage, &gl,
Expand Down