Update dependencies and bindings #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some problematic dependencies: - `ansi_term` and `atty` are deprecated/unmaintained (used by `bindgen`) - we had duplicate `bitflags` versions
Updating the `bindgen` crate forces us to regenerate these bindings.
For some time, Ubuntu has been phasing out support for 32-bit packages (e.g., [here]). `ittapi` still builds a 32-bit version of the library, which requires `gcc-multilib` to be installed (it provides `/usr/include/bits/libc-header-start.h` when compiling with `-m32`). But some GitHub inconsistency is getting in the way: `gcc-multilib` fails to install on the GitHub runner though it can be installed locally. [here]: https://canonical.com/blog/statement-on-32-bit-i386-packages-for-ubuntu-19-10-and-20-04-lts While we figure out the 32-bit support story for `ittapi`, this change disables the 32-bit build by forcing it to be 64-bit exclusively. Once we decide whether to (a) remove 32-bit support or (b) fix the GitHub runners to allow 32-bit builds, we can remove the TODO.
abrown
force-pushed
the
update-dependencies
branch
from
1561a71
to
e7ea2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes fixes some CI issues:
gcc-multilib