This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Show the host ip in fastboot #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouji3x
reviewed
Mar 12, 2021
libfastboot/fastboot_transport.c
Outdated
| @@ -199,7 +231,11 @@ static EFI_STATUS fastboot_tcp_start(start_callback_t start_cb, | |||
| if (EFI_ERROR(ret)) | |||
| return ret; | |||
|
|
|||
| print_tcpip_information(&station_address); | |||
| ret = fastboot_get_host_ip(&station_address2); | |||
There was a problem hiding this comment.
check whether it is running on a KVM virtual by calling is_running_on_kvm().
for bare metal, read host ip from smbios is not necessary
| * host ip to bootloader.*/ | ||
| char *get_host_ip(void) | ||
| { | ||
| static char host_ip[ANDROID_PROP_VALUE_MAX]; |
There was a problem hiding this comment.
why use static? what about define local variable char host_ip[ANDROID_PROP_VALUE_MAX] in fastboot_get_host_ip(), then call get_host_ip(char *host_ip) to get host ip.
There was a problem hiding this comment.
This can be consistent with other functions implemented in vars.c, such as get_device_id, get_property_bootloader etc.
zhouji3x
approved these changes
Mar 12, 2021
This is a W/A, we currently use the asset field of smbios' type_chassis struct to pass the host ip to bootloader. Tracked-On: OAM-96182 Signed-off-by: ji, zhenlong z <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a W/A, we currently use the asset field of smbios'
type_chassis struct to pass the host ip to bootloader.
Tracked-On: OAM-96182
Signed-off-by: ji, zhenlong z [email protected]