Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va_win32: Fix debug build break #759

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

sivileri
Copy link
Contributor

Fix debug build break:

[3/9] Compiling C object va/va_win32.dll.p/win32_va_win32.c.obj
FAILED: va/va_win32.dll.p/win32_va_win32.c.obj
"cl" "-Iva\va_win32.dll.p" "-Iva" "-I..\va" "-I." "-I.." "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/Od" "/Zi" "-DLIBVA_MAJOR_VERSION=2" "/Fdva\va_win32.dll.p\win32_va_win32.c.pdb" /Fova/va_win32.dll.p/win32_va_win32.c.obj "/c" ../va/win32/va_win32.c
../va/win32/va_win32.c(186): error C2231: '.LowPart': left operand points to 'struct', use '->'
../va/win32/va_win32.c(186): error C2231: '.HighPart': left operand points to 'struct', use '->'
../va/win32/va_win32.c(188): error C2231: '.LowPart': left operand points to 'struct', use '->'
../va/win32/va_win32.c(188): error C2231: '.HighPart': left operand points to 'struct', use '->'
[5/9] Compiling C object va/va.dll.p/va_trace.c.obj
ninja: build stopped: subcommand failed.

Fixes: 484f128 ("win32: remove duplicate adapter_luid entry")

CC @dvrogozh @evelikov @XinfengZhang

Fixes: 484f128 ("win32: remove duplicate adapter_luid entry")
Signed-off-by: Sil Vilerino <[email protected]>
Copy link
Contributor

@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dvrogozh dvrogozh merged commit 2a1536a into intel:master Sep 27, 2023
13 checks passed
@sivileri sivileri deleted the fix_build_break branch September 27, 2023 16:06
@evelikov
Copy link
Contributor

Ouch, sorry about that. Should we add a debug build combination to the CI matix?

@sivileri
Copy link
Contributor Author

Ouch, sorry about that. Should we add a debug build combination to the CI matix?

No worries :). Maybe adding a new combination with -Dbuildtype=debug for the meson setup args to https://github.com/intel/libva/blob/master/.github/workflows/windows.yml ?

@dvrogozh
Copy link
Contributor

Maybe adding a new combination with -Dbuildtype=debug for the meson setup args to https://github.com/intel/libva/blob/master/.github/workflows/windows.yml ?

Yes. CI coverage would be nice to have to avoid anything similar in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants