[SYCL][COMPAT] Added compare and unordered compare operations #12998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alcpz
force-pushed
the
Alcpz/math-compare
branch
from
d896b6b to
57e1d49
Compare
AidanBeltonS
approved these changes
Apr 15, 2024
sycl/doc/syclcompat/README.md
Outdated
Comment on lines
1245
to
1262
| template <typename ValueT, class BinaryOperation> | ||
| inline std::enable_if_t< | ||
| std::is_same_v<std::invoke_result_t<BinaryOperation, ValueT, ValueT>, bool>, | ||
| bool> | ||
| compare(const ValueT a, const ValueT b, const BinaryOperation binary_op); | ||
| template <typename ValueT> | ||
| inline std::enable_if_t< | ||
| std::is_same_v<std::invoke_result_t<std::not_equal_to<>, ValueT, ValueT>, | ||
| bool>, | ||
| bool> | ||
| compare(const ValueT a, const ValueT b, const std::not_equal_to<> binary_op); | ||
| template <typename ValueT, class BinaryOperation> | ||
| inline std::enable_if_t<ValueT::size() == 2, ValueT> | ||
| compare(const ValueT a, const ValueT b, const BinaryOperation binary_op); | ||
| template <typename ValueT, class BinaryOperation> | ||
| inline std::enable_if_t< | ||
| std::is_same_v<std::invoke_result_t<BinaryOperation, ValueT, ValueT>, bool>, | ||
| bool> |
There was a problem hiding this comment.
Could we format this differently, it is very challenging to read?
There was a problem hiding this comment.
I've substituted the enable if by a comment that includes the enable_if and what the enable_if does. It's technically describing the line of code, but as you say the three nested std:: calls is difficult to read.
I also removed the not_equal_to<> specialization, as it is more an implementation detail.
Alcpz
force-pushed
the
Alcpz/math-compare
branch
from
35a0f97 to
568f77a
Compare
|
@intel/llvm-gatekeepers This is ready to merge. AWS CI check fails due to an unrelated test. Related issue: #13281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following ordered and unordered comparisons: